Difference between revisions of "Documentation/Nightly/Developers/Tutorials/MigrationGuide/ObsoleteCodeRemoval"
From Slicer Wiki
| Line 63: | Line 63: | ||
'''Before:''' | '''Before:''' | ||
| − | + | <pre> | |
def _setSectionResizeMode(header, *args, **kwargs): | def _setSectionResizeMode(header, *args, **kwargs): | ||
if version.parse(qt.Qt.qVersion()) < version.parse("5.0.0"): | if version.parse(qt.Qt.qVersion()) < version.parse("5.0.0"): | ||
| Line 69: | Line 69: | ||
else: | else: | ||
header.setSectionResizeMode(*args, **kwargs) | header.setSectionResizeMode(*args, **kwargs) | ||
| + | |||
| + | [...] | ||
| + | |||
| + | _setSectionResizeMode(self.horizontalHeader(), 0, qt.QHeaderView.Stretch) | ||
| + | </pre> | ||
'''After:''' | '''After:''' | ||
| − | self.horizontalHeader(0, qt.QHeaderView.Stretch) | + | self.horizontalHeader().setSectionResizeMode(0, qt.QHeaderView.Stretch) |
Revision as of 21:11, 8 March 2019
Home < Documentation < Nightly < Developers < Tutorials < MigrationGuide < ObsoleteCodeRemovalContents
Obsolete Code Removal
This section documents suggested code changes after removing support for a particular features. Each category has a short description, code snippets, a suggested upgrade path, and references to relevant commits.
Qt>=5.0.0: Remove obsolete code supporting Qt4 plugin infrastructure (C++)
These changes apply to Qt loadable modules and designer plugins
qSlicerNAMEModuleWidgetsAbstractPlugin.h
Before:
#include <QtGlobal>
#if(QT_VERSION < QT_VERSION_CHECKS(5, 0, 0))
#include <QDesignerCustomWidgetInterface>
#else
#include <QtUiPlugin/QDesignerCustomWidgetInterface>
#endif
[...]
class Q_SLICER_MODULE_SEGMENTATIONS_WIDGETS_PLUGINS_EXPORT qSlicerSegmentationsModuleWidgetsAbstractPlugin
: public QDesignerCustomWidgetInterface
{
#if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QDesignerCustomWidgetInterface")
#endif
Q_INTERFACES(QDesignerCustomWidgetInterface);
}
After:
#include <QtUiPlugin/QDesignerCustomWidgetInterface>
[...]
class Q_SLICER_MODULE_SEGMENTATIONS_WIDGETS_PLUGINS_EXPORT qSlicerSegmentationsModuleWidgetsAbstractPlugin
: public QDesignerCustomWidgetInterface
{
Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QDesignerCustomWidgetInterface")
Q_INTERFACES(QDesignerCustomWidgetInterface);
}
qSlicerNAMEModule.cxx and qSlicerNAMEModuleWidgetsAbstractPlugin.cxx
Remove:
#if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0)) #include <QtPlugin> Q_EXPORT_PLUGIN2(customwidgetplugin, qSlicerSegmentationsModuleWidgetsPlugin); #endif
Qt>=5.0.0: Simpler use of setSectionResizeMode (Python)
This migration guide points becomes obsolete: Documentation/Nightly/Developers/Tutorials/MigrationGuide#Qt5:_Fix_error:_.E2.80.98class_QHeaderView.E2.80.99_has_no_member_named_.E2.80.98setResizeMode.E2.80.99
Before:
def _setSectionResizeMode(header, *args, **kwargs):
if version.parse(qt.Qt.qVersion()) < version.parse("5.0.0"):
header.setResizeMode(*args, **kwargs)
else:
header.setSectionResizeMode(*args, **kwargs)
[...]
_setSectionResizeMode(self.horizontalHeader(), 0, qt.QHeaderView.Stretch)
After:
self.horizontalHeader().setSectionResizeMode(0, qt.QHeaderView.Stretch)
