Difference between revisions of "Documentation/Nightly/Developers/Tutorials/MigrationGuide/ObsoleteCodeRemoval"

From Slicer Wiki
Jump to: navigation, search
Line 3: Line 3:
 
This section documents suggested code changes after removing support for a particular features. Each category has a short description, code snippets, a suggested upgrade path, and references to relevant commits.
 
This section documents suggested code changes after removing support for a particular features. Each category has a short description, code snippets, a suggested upgrade path, and references to relevant commits.
  
−
===Qt>=5.0.0: QDesignerCustomWidgetInterface header include and Q_PLUGIN_METADATA macro (C++)===
+
===Qt>=5.0.0: Remove obsolete code supporting Qt4 plugin infrastructure (C++)===
 +
 
 +
====qSlicerNAMEModuleWidgetsAbstractPlugin.h updates====
  
 
'''Before:'''
 
'''Before:'''
Line 41: Line 43:
 
   }
 
   }
 
</pre>
 
</pre>
 +
 +
 +
====qSlicerNAMEModule.cxx and qSlicerNAMEModuleWidgetsAbstractPlugin.cxx updates====
 +
 +
'''Remove:'''
 +
 +
  #if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0))
 +
  #include <QtPlugin>
 +
  Q_EXPORT_PLUGIN2(customwidgetplugin, qSlicerSegmentationsModuleWidgetsPlugin);
 +
  #endif
 +
  
 
===Qt>=5.0.0: Simpler use of setSectionResizeMode (Python)===
 
===Qt>=5.0.0: Simpler use of setSectionResizeMode (Python)===

Revision as of 20:48, 8 March 2019

Home < Documentation < Nightly < Developers < Tutorials < MigrationGuide < ObsoleteCodeRemoval

Obsolete Code Removal

This section documents suggested code changes after removing support for a particular features. Each category has a short description, code snippets, a suggested upgrade path, and references to relevant commits.

Qt>=5.0.0: Remove obsolete code supporting Qt4 plugin infrastructure (C++)

qSlicerNAMEModuleWidgetsAbstractPlugin.h updates

Before: 

  #include <QtGlobal>
  #if(QT_VERSION < QT_VERSION_CHECKS(5, 0, 0))
  #include <QDesignerCustomWidgetInterface>
  #else
  #include <QtUiPlugin/QDesignerCustomWidgetInterface>
  #endif

  [...]

  class Q_SLICER_MODULE_SEGMENTATIONS_WIDGETS_PLUGINS_EXPORT qSlicerSegmentationsModuleWidgetsAbstractPlugin
      : public QDesignerCustomWidgetInterface
  {
  #if (QT_VERSION >= QT_VERSION_CHECK(5, 0, 0))
    Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QDesignerCustomWidgetInterface")
  #endif
    Q_INTERFACES(QDesignerCustomWidgetInterface);
  }

After: 

  #include <QtUiPlugin/QDesignerCustomWidgetInterface>

  [...]

  class Q_SLICER_MODULE_SEGMENTATIONS_WIDGETS_PLUGINS_EXPORT qSlicerSegmentationsModuleWidgetsAbstractPlugin
      : public QDesignerCustomWidgetInterface
  {
    Q_PLUGIN_METADATA(IID "org.qt-project.Qt.QDesignerCustomWidgetInterface")
    Q_INTERFACES(QDesignerCustomWidgetInterface);
  }


qSlicerNAMEModule.cxx and qSlicerNAMEModuleWidgetsAbstractPlugin.cxx updates

Remove: 

 #if (QT_VERSION < QT_VERSION_CHECK(5, 0, 0))
 #include <QtPlugin>
 Q_EXPORT_PLUGIN2(customwidgetplugin, qSlicerSegmentationsModuleWidgetsPlugin);
 #endif


Qt>=5.0.0: Simpler use of setSectionResizeMode (Python)

This migration guide points becomes obsolete: Documentation/Nightly/Developers/Tutorials/MigrationGuide#Qt5:_Fix_error:_.E2.80.98class_QHeaderView.E2.80.99_has_no_member_named_.E2.80.98setResizeMode.E2.80.99

Before: 

 _setSectionResizeMode(self.horizontalHeader(), 0, qt.QHeaderView.Stretch)
 def _setSectionResizeMode(header, *args, **kwargs):
   if version.parse(qt.Qt.qVersion()) < version.parse("5.0.0"):
     header.setResizeMode(*args, **kwargs)
   else:
     header.setSectionResizeMode(*args, **kwargs)

After: 

 self.horizontalHeader(0, qt.QHeaderView.Stretch)
Retrieved from "https://www.slicer.org/w/index.php?title=Documentation/Nightly/Developers/Tutorials/MigrationGuide/ObsoleteCodeRemoval&oldid=60862"