Developer Meetings/20150922

To Discuss

• #3844: Extension module categories are added on the bottom
• #2466: CLIs that use DVW nodes crash in MRMLIDImageIO
• See http://wiki.slicer.org/slicerWiki/index.php/Roadmap#4.5_2
• FYI on new/ongoing projects
  • SlicerHeart (Children's Hospital of Philadelphia and Queens)
  • Slicer for pathology slide analysis (U24 supplement with Stonybrook)
• Removal of code for Slicer 4.5

$ ack -C2  "Slicer 4.5"
Libs/MRML/Core/vtkMRMLScene.h
555-
556-    NewSceneEvent = 66030,
557:    MetadataAddedEvent = 66032, // ### Slicer 4.5: Simplify - Do not explicitly set for backward compat. See issue #3472
558-    ImportProgressFeedbackEvent,
559-    SaveProgressFeedbackEvent,

Libs/MRML/Core/vtkMRMLLayoutNode.h
83-      SlicerLayoutFourUpView = 3,
84-      SlicerLayoutOneUp3DView = 4,
85:      SlicerLayoutOneUpSliceView = 5, // XXX Slicer 4.5 - Remove this value. Here only for backward compatibility.
86-      SlicerLayoutOneUpRedSliceView = 6,
87-      SlicerLayoutOneUpYellowSliceView = 7,
--
89-      SlicerLayoutTabbed3DView = 9,
90-      SlicerLayoutTabbedSliceView = 10,
91:      SlicerLayoutLightboxView = 11, // XXX Slicer 4.5 - Remove this value. Here only for backward compatibility.
92-      SlicerLayoutCompareView = 12,
93:      SlicerLayoutSideBySideLightboxView = 13, // XXX Slicer 4.5 - Remove this value. Here only for backward compatibility.
94-      SlicerLayoutNone = 14,
95-      SlicerLayoutDual3DView = 15,
96-      SlicerLayoutConventionalWidescreenView = 16,
97-      SlicerLayoutCompareWidescreenView = 17,
98:      SlicerLayoutSingleLightboxView = 18, // XXX Slicer 4.5 - Remove this value. Here only for backward compatibility.
99-      SlicerLayoutTriple3DEndoscopyView = 19, // Up to here, all layouts are Slicer 3 compatible
100:      SlicerLayout3DPlusLightboxView = 20, // XXX Slicer 4.5 - Remove this value. Here only for backward compatibility.
101-      SlicerLayoutThreeOverThreeView = 21,
102-      SlicerLayoutFourOverFourView = 22,

Modules/Scripted/DICOM/DICOM.py
93-      slicer.dicomListener.stop()
94-
95:# XXX Slicer 4.5 - Remove this. Here only for backward compatibility.
96-DICOM.setDatabasePrecacheTags = DICOMLib.setDatabasePrecacheTags
97-
--
245-    self.detailsPopup = DICOMLib.DICOMDetailsPopup()
246-
247:    # XXX Slicer 4.5 - Remove these. Here only for backward compatibility.
248-    self.dicomBrowser = self.detailsPopup.dicomBrowser
249-    self.tables = self.detailsPopup.tables
--
391-
392-  def onDatabaseDirectoryChanged(self,databaseDirectory):
393:    # XXX Slicer 4.5 - Remove this function. Was here only for backward compatibility.
394-    self.detailsPopup.onDatabaseDirectoryChanged(databaseDirectory)
395-
396-  def messageBox(self,text,title='DICOM'):
397:    # XXX Slicer 4.5 - Remove this function. Was here only for backward compatibility.
398-    #                  Instead, slicer.util.warningDisplay() should be used.
399-    slicer.util.warningDisplay(text, windowTitle=title)

Conclusion

• Csaba will
  • will work on 3844
  • submit a PR to BRAINSTools to change the category of few orphan modules
• Check with Lauren, Francois and Gordon what should be the right approach for #2466